Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Weathermap to work with modern LibreNMS #60

Merged
merged 2 commits into from
May 23, 2019

Conversation

murrant
Copy link
Contributor

@murrant murrant commented May 22, 2019

Fixes:

  • duplicate class name
  • issues with paths
  • direct use of DB credentials and direct DB access
  • map-poller.php doesn't need to boot LibreNMS, it only needs the config
  • use $librenms_base from config.inc.php and define it better there.
  • apparently trailing whitespace removal because my editor doesn't like it :D

@boudreau
Copy link

Hi,

looks like this pull request working with my release.

@donovan-esterhuizen
Copy link

donovan-esterhuizen commented May 23, 2019

@boudreau how do I update my weather map with the changes made?

@donovan-esterhuizen
Copy link

root@nms:/opt/librenms/html/plugins/Weathermap# git pull https://github.com/librenms-plugins/Weathermap.git

Is the above correct?

@laf laf merged commit 2b9e0f2 into librenms-plugins:master May 23, 2019
@boudreau
Copy link

first clone the repo:
git clone https://github.com/librenms-plugins/Weathermap.git

Go in the directory and get the pull request #60 :
git fetch origin pull/60/head:test

Called the branch "test"

and then activate the branch
git checkout test

The pull request has been merge now, so no need , but for futur ref.

@murrant murrant deleted the update-weathermap branch May 24, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants