Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow dash without piped proxy #6485

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

janisslsm
Copy link
Contributor

This also allows you to watch newly released videos, HLS streams seem to be broken for newly released videos.

@Bnyro
Copy link
Member

Bnyro commented Sep 14, 2024

@Bnyro
Copy link
Member

Bnyro commented Sep 14, 2024

I don't really get why DASH works with Local stream extraction enabled, but doesn't if you use a working private Piped instance (no matter if Disable Piped Proxy is enabled or disabled) ...

@janisslsm
Copy link
Contributor Author

I don't really get why DASH works with Local stream extraction enabled, but doesn't if you use a working private Piped instance (no matter if Disable Piped Proxy is enabled or disabled) ...

Yeah, I'm not sure either and I haven't really looked into piped's backend enough to figure it out.

@Bnyro
Copy link
Member

Bnyro commented Sep 14, 2024

Yeah, I'm not sure either and I haven't really looked into piped's backend enough to figure it out.

I've compared the YouTube stream URLs used for playback (with local stream extraction vs Piped instance) and both work fine when pasting the URL in the browser...

@Bnyro Bnyro merged commit b29d4c6 into libre-tube:master Sep 14, 2024
3 checks passed
@janisslsm janisslsm deleted the feat-local-dash branch September 14, 2024 09:59
@Bnyro Bnyro mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants