Renegade: added pwm fan on pins 12,13 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the Le Potato implementation at https://github.com/libre-computer-project/libretech-wiring-tool/blob/master/libre-computer/aml-s905x-cc/dt/pwm-a-fan.dts and adapted to the Renegade
This is my first attempt a writing a DTO file, so I welcome any cleanup / fixes that need to be made. In particular I'm not sure I used the best name for pin 11 when enabling the pull-up, and the '20' on the interrupts line is magic to me. The AML version used a symbol from a header, but no such header currently exists for the rockchip boards (as far as I can tell).
I chose pin 11 for the tach arbitrarily (it was the first one that worked). If there's a better pin that can send interrupts and is less likely to interfere with other GPIO uses, let me know, and I can change it.