Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a basic QUIC spec #499

Merged
merged 4 commits into from
Jan 5, 2023
Merged

add a basic QUIC spec #499

merged 4 commits into from
Jan 5, 2023

Conversation

marten-seemann
Copy link
Contributor

Nothing fancy here. Creating this PR mostly to have a basis for the changes we’re planning for #498. Would appreciate getting this merged soon :)

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of referencing the TLS specification here?

@MarcoPolo
Copy link
Contributor

At least the libp2p TLS extension and the ALPN need to be specified.

marten-seemann and others added 2 commits January 4, 2023 20:58
Co-authored-by: Max Inden <mail@max-inden.de>
@marten-seemann marten-seemann requested a review from mxinden January 5, 2023 05:03
@marten-seemann
Copy link
Contributor Author

@mxinden @MarcoPolo That makes sense. I updated the document.

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up.

@mxinden
Copy link
Member

mxinden commented Jan 5, 2023

Before merging, can you please reference the specification in the root README.md?

@marten-seemann
Copy link
Contributor Author

Before merging, can you please reference the specification in the root README.md?

Done.

@marten-seemann marten-seemann merged commit 76ccc4f into master Jan 5, 2023
@marten-seemann marten-seemann deleted the quic branch January 5, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants