Fix tls.md #357
Merged
Fix tls.md #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tls.md to use OCTET STRING instead of BIT STRING for elements of SignedKey
This was referenced Jul 30, 2021
|
Nice catch! @mxinden what does rust-libp2p do here? |
|
Nothing yet, this was found by @kpp testing the upcoming rust implementation. |
Stebalien
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go implementation uses
OCTET STRINGinstead ofBIT STRINGfor elements ofSignedKey.The options are:
However with 1) we should also notify every implementors to fix it, e.g. https://github.com/alanshaw/js-libp2p-quic/blob/1f3c1dd6dff3c2e94710a1ae76e815e0805c8a99/src/crypto.js#L44