Make the structs in nodes generic over PeerId #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
senden9
reviewed
Jan 22, 2019
| // Set the state of the task to `Connected`. | ||
| let former_task_id = self.parent.nodes.insert(self.peer_id.clone(), self.id); | ||
| let _former_state = self.parent.tasks.insert(self.id, TaskState::Connected(self.peer_id.clone())); | ||
| debug_assert_eq!(_former_state, Some(TaskState::Pending)); | ||
| debug_assert!(_former_state == Some(TaskState::Pending)); |
There was a problem hiding this comment.
Why the change from debug_assert_eq to debug_assert here?
There was a problem hiding this comment.
Otherwise we have to require Debug on the TPeerId.
There was a problem hiding this comment.
Is this not required here? https://github.com/libp2p/rust-libp2p/pull/881/files#diff-87276c9dd75246456f7330545b24dd12R128
TPeerId: Eq + Hash + Clone + fmt::Debug,Edit: Oh, I understand. Impl <…> fmt::Debug for … TPeerId: … + fmt::Debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard-coding the ID of a peer as
PeerId, make it generic.This is a small breaking change as we implement
AsRef<[u8]>onPeerId, which can cause an inference error, but we can consider this as acceptable.