feat(kad): Return multiaddrs alognside peer IDs #5475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiezzel
force-pushed
the
wiezzel/kad_addrs
branch
from
1027356
to
2723ca2
Compare
Wiezzel
force-pushed
the
wiezzel/kad_addrs
branch
from
2723ca2
to
92b5b92
Compare
guillaumemichel
requested changes
Jun 20, 2024
Co-authored-by: Guillaume Michel <guillaumemichel@users.noreply.github.com>
Wiezzel
force-pushed
the
wiezzel/kad_addrs
branch
2 times, most recently
from
b6e277a
to
23592ae
Compare
Wiezzel
force-pushed
the
wiezzel/kad_addrs
branch
from
23592ae
to
8d6fb8b
Compare
guillaumemichel
approved these changes
Jun 21, 2024
|
Sorry to review after merge but why increase the version of |
|
@stormshield-frb I'm sorry. I'm no up-to-date with the release schedule. |
Good point! We'll address it in a follow up PR shortly. |
guillaumemichel
added a commit
that referenced
this pull request
Jun 25, 2024
TimTinkers
pushed a commit
to unattended-backpack/rust-libp2p
that referenced
this pull request
Sep 14, 2024
Pull-Request: libp2p#5475.
TimTinkers
pushed a commit
to unattended-backpack/rust-libp2p
that referenced
this pull request
Sep 14, 2024
Correct `kad` changelog after libp2p#5475 `kad` `0.46.0` isn't released yet, hence changelog entry from libp2p#5475 will be published with `0.46.0`. Pull-Request: libp2p#5478.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes & open questions
Change checklist