Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kad): FIND_NODE for own peer id returns closest peers #5270

Merged
merged 3 commits into from
Mar 28, 2024
Merged

feat(kad): FIND_NODE for own peer id returns closest peers #5270

merged 3 commits into from
Mar 28, 2024

Conversation

guillaumemichel
Copy link
Contributor

@guillaumemichel guillaumemichel commented Mar 26, 2024 •
edited
Loading

Description

Fixes #5269.

Notes & open questions

FIND_NODE response should not contain self nor the requester ID, but should never be empty if it has any other peers in the routing table.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (no changes required)
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@guillaumemichel guillaumemichel mentioned this pull request Mar 26, 2024
Closed
@jxs jxs changed the title FIND_NODE for own peer id returns closest peers feat(kad): FIND_NODE for own peer id returns closest peers Mar 27, 2024
jxs
jxs approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Gui LGTM, can you add a CHANGELOG.MD entry and version bump (since this is a breaking change)?

jxs
jxs approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Gui!

@jxs jxs added the send-it label Mar 28, 2024
@mergify mergify bot merged commit 695404d into master Mar 28, 2024
71 of 72 checks passed
@mergify mergify bot deleted the fix/findnode-self branch March 28, 2024 12:48
guillaumemichel added a commit that referenced this pull request Mar 28, 2024
@guillaumemichel
feat(kad): FIND_NODE for own peer id returns closest peers
f792b58 
Fixes #5269.

Pull-Request: #5270.
@Wiezzel Wiezzel mentioned this pull request Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kad: FIND_NODE not conform to specs
2 participants
@guillaumemichel @jxs