-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kad): re-export NodeStatus
#4645
Conversation
For a little more context I have code very similar to this which checks for disconnected nodes. Without this change it is impossible to upgrade to v0.52 from v0.51 of libp2p for this specific case. |
f0f875b
to
334c5b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch!
This needs a changelog entry before we can merge it. Plus, while I appreciate the consistency, I wonder whether just NodeStatus
wouldn't be descriptive enough when used as kad::NodeStatus
?
NodeStatus
I've added this to the release milestone to make sure we merge it before we cut the next breaking release. |
NodeStatus
NodeStatus
The EntryView struct exposes the node status however its type is not public making it impossible to use the status field. This change re-exports NodeStatus according to the existing naming pattern. See libp2p#4108 which was fixed however the NodeStatus type was not exposed.
30a3a2c
to
3231af0
Compare
@thomaseizinger Thanks for the review, I have updated the change and added CHANGELOG entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
The
EntryView
struct exposes the node status however its type is not public making it impossible to use the status field. This change re-exportsNodeStatus
.Related: #4108.
Change checklist