fix(dcutr): exchange address candidates #4624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
approved these changes
Oct 16, 2023
|
The dcutr example currently does not work. I attempted to fix this in #4672. |
mxinden
reviewed
Oct 19, 2023
Co-authored-by: Max Inden <mail@max-inden.de>
This comment was marked as resolved.
This comment was marked as resolved.
mxinden
approved these changes
Oct 24, 2023
This comment was marked as resolved.
This comment was marked as resolved.
thomaseizinger
commented
Oct 25, 2023
This comment was marked as resolved.
This comment was marked as resolved.
|
Let's merge #4549 before this one. |
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a serious of refactorings, we seem to have introduced a bug where we where exchanged the external addresses of our node as part of
libp2p-dcutr. This is ironically quite pointless. If we have external addresses, then there is no need for hole-punching (i.e. DCUtR).Instead of gathering external addresses, we use an LRU cache to store our observed addresses. Repeatedly observed addresses will be tried first which should increase the success rate of a hole-punch.
Resolves: #4496.
Notes & open questions
Change checklist