feat(kad): migrate to quick-protobuf-codec crate #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
approved these changes
Sep 14, 2023
|
Seems you missed to checkin changes to the lockfile :) |
mxinden
reviewed
Sep 14, 2023
thomaseizinger
previously approved these changes
Sep 14, 2023
mergify
bot
dismissed
thomaseizinger’s stale review
Approvals have been dismissed because the PR was updated after the send-it label was applied.
thomaseizinger
approved these changes
Sep 15, 2023
StemCll
pushed a commit
to StemCll/rust-libp2p
that referenced
this pull request
Sep 17, 2023
Resolves libp2p#4487. Pull-Request: libp2p#4501.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4487.
Notes & open questions
Much thanks to @thomaseizinger for the very useful pointers!
Change checklist