See 767 instead. gossipsub: an extensible baseline pubsub protocol #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructs_proto from floodsublib with floosub import and overlay parameters
jamesray1
changed the title
jamesray1
changed the title
This was referenced Aug 17, 2018
… script, generate rpc_proto.rs, add constants, add commented out code to lib.rs, add an UNLICENSE.
…impl without any changes to FloodSubUpgrade
…impl without any changes to FloodSubUpgrade
|
So for extending floodsub, it seems like for adding new fields to structs the best way available in Rust is by composition, as inheritance isn't supported. E.g.: struct StructB {
a: StructA,
// other fields...
} |
…fixing types, etc.
|
So far I need to use these private things: // libp2p_floodsub::{RemoteInfo, Inner,
// FloodSubController.broadcast()}Shall we make them public, or implement getters for them? |
This was referenced Sep 25, 2018
|
Replaced by #521. |
jamesray1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outdated, see #767.
There is a PR with a spec here. Previously I was implementing episub in #291, however that extends on gossipsub, so it's better to implement gossipsub first. It's taking a while to really get into development as I've been reading through relevant specs, code, learnt Go, tokio, protobuf, and how to best extend on floodsub in terms of code structure e.g. with traits.
For a comparison of rpc_proto.rs and rpc.proto between gossipsub and floodsub, see #428.