Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(identity): expose KeyType for PublicKey and Keypair #4107

Merged
merged 6 commits into from
Jun 26, 2023
Merged

feat(identity): expose KeyType for PublicKey and Keypair #4107

merged 6 commits into from
Jun 26, 2023

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Jun 23, 2023 •
edited by thomaseizinger
Loading

Description

Resolves #3649.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@gurinderu gurinderu changed the title Added a key_type to PublicKey and KeyPair feat(identity): Added a key_type to PublicKey and KeyPair Jun 23, 2023
@thomaseizinger thomaseizinger changed the title feat(identity): Added a key_type to PublicKey and KeyPair feat(identity): expose KeyType for PublicKey and Keypair Jun 26, 2023
thomaseizinger
thomaseizinger previously approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

identity/CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot dismissed thomaseizinger’s stale review June 26, 2023 17:30

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@mergify mergify bot merged commit 78510ed into libp2p:master Jun 26, 2023
This was referenced Jun 27, 2023
Merged
Closed
mergify bot pushed a commit that referenced this pull request Jun 27, 2023
@thomaseizinger
fix(identity): bump version
5c362fc 
In #4107, we forgot to bump the version of `libp2p-identity`.

Pull-Request: #4125.


  
Co-Authored-By: Thomas Eizinger <thomas@eizinger.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@mxinden mxinden mxinden left review comments

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

identity::Keypair ergonomics improvements
3 participants
@gurinderu @thomaseizinger @mxinden