feat(swarm): make stream uprade errors more ergonomic #3882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-libp2p into feat/no-report-inbound-error
thomaseizinger
commented
May 5, 2023
mxinden
approved these changes
May 8, 2023
Comment on lines
+472
to
+473
| /// No protocol could be agreed upon. | ||
| NegotiationFailed, |
There was a problem hiding this comment.
As a side-note, we had multiple users complain, that it is hard to debug why the negotiation failed. What would have helped them is NegotiationFailed to contain the protocols the local and the remote peer offered.
That said, using DEBUG logging and looking for the multistream-select lines also helps the debugging, though a bit harder to discover.
Not to be addressed in this pull request.
There was a problem hiding this comment.
Including this information will be a breaking change but we can introduce the facilities for it in a non-breaking manner once we have completely encapsulated multistream-select, meaning this is a step in the right direction in my opinion.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Max Inden <mail@max-inden.de>
…2p/rust-libp2p into 3759-encapsulate-multistream-select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The currently provided
ConnectionHandlerUpgrErris very hard to use. Not only does it have a long name, it also features 3 levels of nesting which results in a lot of boilerplate. Last but not least, it exposesmultistream-selectas a dependency to all protocols.We fix all of the above by renaming the type to
StreamUpgradeErrorand flattening out its interface. Unrecoverable errors during protocol selection are hidden within theIovariant.Related: #3759.
Notes & open questions
Draft because it depends on #3605.Change checklist