Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump clap from 4.2.1 to 4.2.4 #3808

Merged
merged 4 commits into from
Apr 28, 2023
Merged

deps: bump clap from 4.2.1 to 4.2.4 #3808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9697ebb
deps: bump clap from 4.2.1 to 4.2.4
dependabot[bot] Apr 19, 2023
f26243b
Merge branch 'master' into dependabot/cargo/clap-4.2.4
mergify[bot] Apr 24, 2023
75fb553
Merge branch 'master' into dependabot/cargo/clap-4.2.4
thomaseizinger Apr 28, 2023
3093ac4
Merge branch 'master' into dependabot/cargo/clap-4.2.4
mergify[bot] Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 38 additions & 38 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/autonat/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ license = "MIT"

[dependencies]
async-std = { version = "1.12", features = ["attributes"] }
clap = { version = "4.2.1", features = ["derive"] }
clap = { version = "4.2.4", features = ["derive"] }
env_logger = "0.10.0"
futures = "0.3.28"
libp2p = { path = "../../libp2p", features = ["async-std", "tcp", "noise", "yamux", "autonat", "identify", "macros"] }
2 changes: 1 addition & 1 deletion examples/dcutr/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ publish = false
license = "MIT"

[dependencies]
clap = { version = "4.2.1", features = ["derive"] }
clap = { version = "4.2.4", features = ["derive"] }
env_logger = "0.10.0"
futures = "0.3.28"
futures-timer = "3.0"
Expand Down
2 changes: 1 addition & 1 deletion examples/file-sharing/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ license = "MIT"
[dependencies]
async-std = { version = "1.12", features = ["attributes"] }
async-trait = "0.1"
clap = { version = "4.2.1", features = ["derive"] }
clap = { version = "4.2.4", features = ["derive"] }
either = "1.8"
env_logger = "0.10"
futures = "0.3.28"
Expand Down
2 changes: 1 addition & 1 deletion examples/relay-server/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ publish = false
license = "MIT"

[dependencies]
clap = { version = "4.2.1", features = ["derive"] }
clap = { version = "4.2.4", features = ["derive"] }
async-std = { version = "1.12", features = ["attributes"] }
async-trait = "0.1"
env_logger = "0.10.0"
Expand Down
2 changes: 1 addition & 1 deletion misc/keygen/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ categories = ["network-programming", "asynchronous"]
publish = false

[dependencies]
clap = { version = "4.2.1", features = ["derive"] }
clap = { version = "4.2.4", features = ["derive"] }
zeroize = "1"
serde = { version = "1.0.160", features = ["derive"] }
serde_json = "1.0.95"
Expand Down
2 changes: 1 addition & 1 deletion protocols/dcutr/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ void = "1"

[dev-dependencies]
async-std = { version = "1.12.0", features = ["attributes"] }
clap = { version = "4.2.1", features = ["derive"] }
clap = { version = "4.2.4", features = ["derive"] }
env_logger = "0.10.0"
libp2p-dns = { path = "../../transports/dns", features = ["async-std"] }
libp2p-identify = { path = "../../protocols/identify" }
Expand Down
2 changes: 1 addition & 1 deletion protocols/perf/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ categories = ["network-programming", "asynchronous"]
[dependencies]
anyhow = "1"
async-std = { version = "1.9.0", features = ["attributes"] }
clap = { version = "4.2.1", features = ["derive"] }
clap = { version = "4.2.4", features = ["derive"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This being part of the regular dependencies adds a lot of code for users that activate the perf feature.

It is for testing only but I think I'd still feel better if these dependencies wouldn't be part of our normal dependency tree.

Not sure if we've previously discussed this but perhaps we should remove perf from our optional libp2p dependencies such that it doesn't show up as part of full?

cc @mxinden

Copy link
Member

@mxinden mxinden Apr 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed it here #3508 (comment), though from a different perspective.

I don't think removing-from-full is worth the inconsistency it introduces. Users should not be surprised that compile times are high when they use full. In terms of CI speed, we would need to build clap either way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fair points.

env_logger = "0.10.0"
futures = "0.3.28"
instant = "0.1.11"
Expand Down