-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kad): export RoutingUpdate
#3739
Conversation
The enum was already `pub`, but not exported. Fixes libp2p#3737
c7d1872
to
7c61b53
Compare
kad
's RoutingUpdate
available publiclyRoutingUpdate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you add a changelog entry and bump the version if there isn't yet an unreleased section in the changelog of |
I've changed the version from |
I believe the patch bump is fine to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 thanks for working on the patch!
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
Description
The
RoutingUpdate
type thatadd_address
returns was not made available publicly. This type is added in this PR bypub use
.Resolves #3737.
Notes & open questions
Change checklist