Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(identity): implement Copy for identity::secp256k1::KeyPair #3707

Closed
wants to merge 3 commits into from
Closed

feat(identity): implement Copy for identity::secp256k1::KeyPair #3707

wants to merge 3 commits into from

Conversation

thomaseizinger
Copy link
Contributor

Description

Related: #3649.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger mentioned this pull request Mar 30, 2023
Closed
@mergify

This comment was marked as resolved.

Sign in to view
mxinden
mxinden reviewed Apr 5, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, though what is the rational? None of the other keypair types implement Copy. Why treat secp256k1 differently? Are we sure the underlying library will always make its type Copy?

@thomaseizinger
Copy link
Contributor Author

Fine by me, though what is the rational?

It means Clone of the combined keypair can use the Copy impl of this keypair.

I am not sure if it will always be exposed so yeah, it might be a hazard later.

Let's not do it.

@mxinden
Copy link
Member

mxinden commented Apr 5, 2023

None of the other keypair types implement Copy

For the avid reader, the above is not correct. We do have #3706 now.

@thomaseizinger thomaseizinger deleted the feat/secp256k1-copy branch April 26, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden