Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(metrics): move example to examples/ #3661

Merged
merged 5 commits into from
Apr 11, 2023
Merged

chore(metrics): move example to examples/ #3661

merged 5 commits into from
Apr 11, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

Related: #3111.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger requested a review from mxinden March 22, 2023 20:45
@mergify
Copy link
Contributor

mergify bot commented Apr 3, 2023

This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏

@thomaseizinger
Copy link
Contributor Author

Merging because trivial.

@mergify mergify bot merged commit f7c3db9 into master Apr 11, 2023
@mergify mergify bot deleted the move-metrics-example branch April 11, 2023 20:47
mxinden
mxinden reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden left review comments

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden