Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use target_arch instead of target_os for wasm cfg's #3572

Merged
merged 3 commits into from
Mar 10, 2023
Merged

refactor: use target_arch instead of target_os for wasm cfg's #3572

merged 3 commits into from
Mar 10, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

As far as I can tell, this is equivalent and less verbose.

Notes

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger requested a review from mxinden March 8, 2023 17:34
mxinden
mxinden approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any expertise here. Fine by me.

@mergify mergify bot merged commit c06731b into master Mar 10, 2023
@mergify mergify bot deleted the feat/arch-instead-of-os branch March 10, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden