Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Fix newly raised clippy warnings (backport #3106) #3472

Closed

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 15, 2023

This is an automatic backport of pull request #3106 done by Mergify.
Cherry-pick of c32f03c has failed:

On branch mergify/bp/rust-v0480-testplan/pr-3106
Your branch is up to date with 'origin/rust-v0480-testplan'.

You are currently cherry-picking commit c32f03c3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   core/src/identity/ecdsa.rs
	modified:   examples/chat-tokio.rs
	modified:   examples/chat.rs
	modified:   examples/distributed-key-value-store.rs
	modified:   examples/file-sharing.rs
	modified:   examples/ipfs-kad.rs
	modified:   examples/ipfs-private.rs
	modified:   examples/mdns-passive-discovery.rs
	modified:   examples/ping.rs
	modified:   muxers/mplex/src/codec.rs
	modified:   protocols/gossipsub/src/behaviour.rs
	modified:   protocols/gossipsub/src/peer_score.rs
	modified:   protocols/gossipsub/src/peer_score/tests.rs
	modified:   protocols/gossipsub/src/subscription_filter.rs
	modified:   protocols/kad/src/kbucket/key.rs
	modified:   protocols/relay/src/v2/relay.rs
	modified:   protocols/rendezvous/src/client.rs
	modified:   protocols/rendezvous/src/server.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   examples/gossipsub-chat.rs
	both modified:   protocols/kad/src/query/peers/closest/disjoint.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Fixed minor issues raised by clippy to improve correctness and readablitity.

(cherry picked from commit c32f03c)

# Conflicts:
#	examples/gossipsub-chat.rs
#	protocols/kad/src/query/peers/closest/disjoint.rs
@mergify mergify bot added the conflicts label Feb 15, 2023
@mergify mergify bot mentioned this pull request Feb 15, 2023
2 tasks
@thomaseizinger
Copy link
Contributor

Not worth it.

@mergify mergify bot deleted the mergify/bp/rust-v0480-testplan/pr-3106 branch February 15, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants