Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swarm)!: remove unused PendingConnectionError::Io variant #3373

Merged
merged 7 commits into from
Jan 26, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

This variant is never constructed.

Notes

Discovered whilst trying to sort out the error situation in #3254.

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

swarm/CHANGELOG.md Outdated Show resolved Hide resolved
swarm/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@mxinden
Copy link
Member

mxinden commented Jan 25, 2023

Adding send-it label. Given that this is not a draft pull request and given that it targets the master branch, I am assuming that this is not a "stacked pull request".

@thomaseizinger
Copy link
Contributor Author

Adding send-it label. Given that this is not a draft pull request and given that it targets the master branch, I am assuming that this is not a "stacked pull request".

Correct, there are more on top of this one :)

@thomaseizinger
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jan 25, 2023

refresh

✅ Pull request refreshed

@thomaseizinger
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jan 25, 2023

refresh

✅ Pull request refreshed

@thomaseizinger
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2023

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 90af08c into master Jan 26, 2023
@mergify mergify bot deleted the 2824-remove-unused-error branch January 26, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants