feat(noise): deprecate LegacyConfig without replacement
#3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
approved these changes
Dec 22, 2022
mxinden
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
Deprecation first sounds ideal to me.
I suggest adding a short changelog entry never the less. What do you think @thomaseizinger?
|
This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏 |
|
929cbb4#diff-022f11eec986ac7c281f192c0e10064513ee5ef6ad2ab45d5dc0c3bbdc617b2f is another good example that our changelog management is flawed and prone to errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the name implies,
LegacyConfigallows users to interact with older versions of the noise protocol. These are not interoperable and we've been supporting them for a long time now. Hopefully, users have migrated away from it since. To not directly break them, we officially deprecate now without a replacement.Notes
Raised by @mxinden in #3227 (review).
Links to any relevant issues
Open Questions
Change checklist