Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove dialer_can_receive stream muxer test #3108

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Nov 10, 2022

Description

Various muxer implementations struggle to fulfill this test. In practice, it doesn't matter much because we always run multistream-select on top of a newly negotiated stream so we never end up actually reading from a stream that we have never written to.

Relevant discussion: kpp#27 (comment)

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger requested a review from a team November 10, 2022 21:53
elenaf9 added a commit to kpp/rust-libp2p that referenced this pull request Nov 12, 2022
Test will be removed completely from the test harness in libp2p#3108.
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with keeping it. I.e. I am fine with keeping a test that is only green on mplex.

That said, I don't think mplex is particularly relevant for rust-libp2p and thus I am fine removing it. Your call.

@thomaseizinger
Copy link
Contributor Author

I am fine with keeping it. I.e. I am fine with keeping a test that is only green on mplex.

That said, I don't think mplex is particularly relevant for rust-libp2p and thus I am fine removing it. Your call.

My goal with this test suite is to act as a first step towards standardising, how streams in (rust-)libp2p should behave. A test that is only green on some implementations doesn't help with that.

@mergify mergify bot merged commit 5b3612b into master Nov 14, 2022
@thomaseizinger thomaseizinger deleted the remove-dialer-read-stream-test branch November 17, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants