Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of protocol relevant information #2814

Closed
wants to merge 2 commits into from

Conversation

AbhijithGanesh
Copy link

Signed-off-by: Abhijith Ganesh 67182544+AbhijithGanesh@users.noreply.github.com

Description

Implementation of logs that will log the type of protocol used and other relevant information relevant to track usage.

Links to any relevant issues

Link to Issue

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Signed-off-by: Abhijith Ganesh <67182544+AbhijithGanesh@users.noreply.github.com>
@AbhijithGanesh
Copy link
Author

@thomaseizinger and @mxinden I would need help with this, can you review the PR and tell me what I am missing?

@AbhijithGanesh AbhijithGanesh marked this pull request as draft August 11, 2022 16:30
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This is a good start. Can you please:

  • Add some tests
  • Integrate with the Recorder infrastructure of the libp2p_metrics crate to automatically increment and decrement a gauge based on a SwarmEvent

@AbhijithGanesh
Copy link
Author

I shall do the required

@thomaseizinger
Copy link
Contributor

Closing this in favor of #2982.

@thomaseizinger
Copy link
Contributor

Thanks for your work anyway @AbhijithGanesh ! I closed this here because #2982 is closer to being merged and I want to avoid duplicate work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants