Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm/src/connection/pool: Remove 'a lifetime in PoolEvent #2625

Merged
merged 3 commits into from
May 4, 2022
Merged

swarm/src/connection/pool: Remove 'a lifetime in PoolEvent #2625

merged 3 commits into from
May 4, 2022

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented May 2, 2022

Description

Simplifies PoolEvent, no longer carrying a reference to an
EstablishedConnection or the Pool, but instead the PeerId,
ConnectionId and ConnectedPoint directly.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
    • No change in functionality.
  • A changelog entry has been made in the appropriate crates
    • Not needed. PoolEvent is not exposed.

@mxinden
swarm/src/connection/pool: Remove 'a lifetime in PoolEvent
c34ecbf 
Simplifies `PoolEvent`, no longer carrying a reference to an
`EstablishedConnection` or the `Pool`, but instead the `PeerId`,
`ConnectionId` and `ConnectedPoint` directly.
@mxinden mxinden requested review from thomaseizinger and elenaf9 May 2, 2022 14:14
@mxinden mxinden mentioned this pull request May 2, 2022
Merged
4 tasks
elenaf9
elenaf9 approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

swarm/src/connection/pool.rs Outdated Show resolved Hide resolved
mxinden
mxinden commented May 2, 2022
View reviewed changes
swarm/src/connection/pool.rs Outdated Show resolved Hide resolved
@mxinden @elenaf9
Apply suggestions from code review
116ba10 
Co-authored-by: Elena Frank <elena.frank@protonmail.com>
thomaseizinger
thomaseizinger approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@mxinden mxinden merged commit 3cfbf89 into libp2p:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@elenaf9 elenaf9 elenaf9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxinden @thomaseizinger @elenaf9