Add get_address_proto to handle trailing "tls/ws" in multiaddr

[jochasinga]

Before returning Ws protocol when hitting the last trailing /ws in a multiaddr,
check to see if the next path segment is /tls. If it is, then return Wss instead.
This addresses #2449 the deprecated /wss specifier for the new /tls/ws in the spec.

[thomaseizinger]

Thanks!

Some ideas for how this could be improved :)

[tomaka]

I guess this is a first step 👍 , but for #2449 to be finished we need a couple more changes, such as producing /tls/ws when receiving an incoming connection. Ultimately Protocol::Wss shouldn't be used except specifically for backwards compatibility.

[jochasinga]

I guess this is a first step 👍 , but for #2449 to be finished we need a couple more changes, such as producing /tls/ws when receiving an incoming connection. Ultimately Protocol::Wss shouldn't be used except specifically for backwards compatibility.

Could you elaborate on those two points @tomaka ?

[jochasinga]

@tomaka or @thomaseizinger some help on finishing this up?

[thomaseizinger]

I can't comment on what @tomaka said unfortunately. I am not familiar enough with the code here.

[mxinden]

I am not particularly familiar with this code. @tomaka your input would be more helpful here.

In regards to above comment on this still missing some parts, if I am not mistaken the code below would append a ws or wss, but not a tls/ws:

rust-libp2p/transports/websocket/src/framed.rs

Lines 165 to 166 in 90140a6

	local_addr = local_addr.with(proto.clone());
	remote_addr = remote_addr.with(proto.clone());

Is that of some help @jochasinga?