core/: Merge pending and established connection limits #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pending and established limits for both incoming and outgoing connections. More specifically merge `ConnectionLimits::with_max_pending_incoming` with `ConnectionLimits::with_max_established_incoming` and `ConnectionLimits::with_max_pending_outgoing` with `ConnectionLimits::with_max_established_outgoing`. Connection limits are checked on `Network::dial` for outgoing and on `Network::accept` for incoming connections. This (a) simplifies connection limits from an implementations and user perspective and (b) simplifies returning a connection handler on limit error as limits can only be exceeded at the start of dialing and accepting. See [1]. [1]: libp2p#2242 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge pending and established limits for both incoming and outgoing
connections. More specifically merge
ConnectionLimits::with_max_pending_incomingwithConnectionLimits::with_max_established_incomingandConnectionLimits::with_max_pending_outgoingwithConnectionLimits::with_max_established_outgoing. Connection limits arechecked on
Network::dialfor outgoing and onNetwork::acceptforincoming connections.
This (a) simplifies connection limits from an implementations and user
perspective and (b) simplifies returning a connection handler on limit
error as limits can only be exceeded at the start of dialing and
accepting. See 1.