Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/tutorial: Enhance docs on multiaddrs #2187

Merged
merged 5 commits into from
Aug 9, 2021

Conversation

elenaf9
Copy link
Contributor

@elenaf9 elenaf9 commented Aug 9, 2021

With #2100, the tutorial and examples were changed to print not only one listening address, but instead each one that is reported via a SwarmEvent::NewListenAddr. This resulted in the docs not fitting the actual stdout prints, as they implied that there is only one listening address.
This PR fixes the docs, please feel free to nitpick my wording.

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elenaf9. Very much appreciated!

@mxinden mxinden merged commit 68b5f74 into libp2p:master Aug 9, 2021
@elenaf9 elenaf9 deleted the tutorial/fix-multiaddr-docs branch August 9, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants