Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade js-sys to fix compilation #2023

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Upgrade js-sys to fix compilation #2023

merged 2 commits into from
Apr 1, 2021

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Mar 31, 2021

Fixes #2020

mxinden
mxinden reviewed Mar 31, 2021
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dvdplm! Were you able to find the concrete reason for the compile failure? Has there been a non-semver-compliant upstream release, or is the mistake on our end?

I can cut a new release later today.

@dvdplm
Copy link
Contributor Author

dvdplm commented Apr 1, 2021

Thanks @dvdplm! Were you able to find the concrete reason for the compile failure? Has there been a non-semver-compliant upstream release, or is the mistake on our end?

I have no idea tbh, made close to zero effort to figure out why it was failing. Sorry!

@mxinden mxinden merged commit c0f74aa into master Apr 1, 2021
@mxinden
Copy link
Member

mxinden commented Apr 1, 2021

libp2p-wasm-ext v0.28.1 published and tagged.

@mxinden mxinden deleted the dp-fix-js-sys-dep branch September 26, 2021 12:25
lopopolo added a commit to Kijewski/iana-time-zone that referenced this pull request Sep 30, 2022
@lopopolo
Bump minimal version of js-sys to 0.3.50
23d7589 
This fixes the compilation errors with -Zminimal-versions, but I don't know why.
I couldn't find anything in the wasm-bindgen changelogs, but I found these:

- libp2p/rust-libp2p#2020
- libp2p/rust-libp2p#2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error: could not compile js-sys
2 participants
@dvdplm @mxinden