protocols/request-response: Derive Clone for {Inbound,Outbound}Failure #1891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
InboundFailure
andOutboundFailure
implementingClone
a user oflibp2p-request-response
can handle a failure in one place, and record the failure for statistical purposes (e.g. a monitoring system) in a different place without the need to introduce a new structure for the latter code path.While the above would benefit Substrate (see paritytech/substrate#7478 (comment)) it does allow ambiguity in terms of where an error that has been cloned before should be handled. For more details see the discussion on Substrate linked before.