core/Cargo.toml: Require parity-multiaddr 0.9.2 for Ord bound #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With b601ed4 libp2p-core requires the `Ord` bound on `Multiaddr`. This bound is only implemented with parity-multiaddr `0.9.2`. Make sure libp2p-core requires at least parity-multiaddr `0.9.2`.
romanb
approved these changes
Sep 10, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With b601ed4 libp2p-core requires the
Ordbound onMultiaddr. Thisbound is only implemented with parity-multiaddr
0.9.2. Make surelibp2p-core requires at least parity-multiaddr
0.9.2.I am not sure it is worth the patch release of both libp2p-core and libp2p. Let me know. Happy to do the release.