Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/src: Remove poll_broadcast connection notification mechanism #1527

Merged
merged 3 commits into from
Mar 31, 2020

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Mar 30, 2020

The Network::poll_broadcast function has not proven to be useful. This
commit removes the mechanism all the way down to the connection manager.

With poll_broadcast gone there is no mechanism left to send commands
to pending connections. Thereby command buffering for pending
connections is not needed anymore and is thus removed in this commit as
well.


Fixes #1465.

Replaces #1501.

The `Network::poll_broadcast` function has not proven to be useful. This
commit removes the mechanism all the way down to the connection manager.

With `poll_broadcast` gone there is no mechanism left to send commands
to pending connections. Thereby command buffering for pending
connections is not needed anymore and is thus removed in this commit as
well.
core/src/connection/manager.rs Outdated Show resolved Hide resolved
Co-Authored-By: Pierre Krieger <pierre.krieger1708@gmail.com>
@mxinden
Copy link
Member Author

mxinden commented Mar 30, 2020

Thanks for the quick review. I will leave this open for another day in case anyone out there depends on poll_broadcast and has objections.

@romanb romanb merged commit bc45503 into libp2p:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential unbounded buffer growth in background task of pending connection.
3 participants