feat: allow sent messages seen as subscribed #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
pushed a commit
to eqlabs/rust-ipfs
that referenced
this pull request
Mar 25, 2020
the v0.16.2-with-floodsub-opts includes "subscribers see locally published messages" which is needed for the conformance tests to pass. this has been PR'd as libp2p/rust-libp2p#1520.
koivunej
pushed a commit
to eqlabs/rust-ipfs
that referenced
this pull request
Mar 25, 2020
the v0.16.2-with-floodsub-opts includes "subscribers see locally published messages" which is needed for the conformance tests to pass. this has been PR'd as libp2p/rust-libp2p#1520.
2 tasks
koivunej
pushed a commit
to eqlabs/rust-ipfs
that referenced
this pull request
Mar 25, 2020
the v0.16.2-with-floodsub-opts includes "subscribers see locally published messages" which is needed for the conformance tests to pass. this has been PR'd as libp2p/rust-libp2p#1520.
koivunej
pushed a commit
to rs-ipfs/rust-ipfs
that referenced
this pull request
Mar 25, 2020
* add: pubsub http api * add: get shoveling and subscription complications going currently the missing piece is seeing locally sent messages in the subscribed streams, then maybe creating a more complicated API for subscribing which will require a single task for shoveling into the responses. * chore: lower timeout to pass the tests Should probably have another drop sender here. * fix: close stream on first error tokio::sync::broadcast will continue after telling how many items were lost, which seems likely with the small buffer and quickly firing more than the buffer elements. * fix: raise the buffer size for subscribe responses * feat: use custom rust-libp2p to pass tests the v0.16.2-with-floodsub-opts includes "subscribers see locally published messages" which is needed for the conformance tests to pass. this has been PR'd as libp2p/rust-libp2p#1520. * fix: pubsub test after changing the floodsub impl
tomaka
requested changes
Mar 26, 2020
|
Rebased on top of latest master, renames:
I think this covers everything noted. |
tomaka
reviewed
Apr 2, 2020
minor feature to allow mimicing the behaviour expected by ipfs api tests.
|
Rebased on top of master. Looks like the #1532 didn't include an update to CHANGELOG as there was no conflict. |
tomaka
approved these changes
Apr 6, 2020
mxinden
approved these changes
Apr 6, 2020
Co-Authored-By: Max Inden <mail@max-inden.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor feature to allow mimicing the behaviour expected by ipfs http api tests. default behaviour is not changed.