[mplex] Fix missed task notifications. #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses libp2p#1206 by always registering the current task before calling poll_*_notify functions. This is in the same spirit as the corresponding fix for yamux in libp2p/rust-yamux#54. Also adds missing registration of the current task in close() and flush_all(), which have been observed to cause stalls when trying to do a graceful connection shutdown / close.
romanb
changed the title
tomaka
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1206 by always registering the current task before calling
poll_*_notifyfunctions. This is in the same spirit as the corresponding fix for yamux in libp2p/rust-yamux#54.Also adds missing registration of the current task in
close()andflush_all(), which have been observed to cause stalls when trying to do a graceful connection shutdown / close in certain tests. This is the issue I was running into in the context of some other work and which caused me to submit this patch to cover #1206 as well.