Merge branch '2650-remove-either-error' into 2650-remove-either-trans…

…port
libp2p · Jan 17, 2023 · fdfaf72 · fdfaf72
2 parents 7060f4b + bb84906
commit fdfaf72
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -298,11 +298,12 @@ jobs:
           require_scope: false
 
       - name: Check PR title length
+        env:
+          TITLE: ${{ github.event.pull_request.title }}
         run: |
-          title="${{ github.event.pull_request.title }}"
-          title_length=${#title}
+          title_length=${#TITLE}
           if [ $title_length -gt 72 ]
           then
             echo "PR title is too long (greater than 72 characters)"
             exit 1
-          fi
+          fi
diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md
@@ -12,7 +12,7 @@
 
 - Improve error messages in case keys cannot be decoded because of missing feature flags. See [PR 2972].
 
-- Remove `EitherError` in favor of `either::Either`. See [PR XXXX].
+- Remove `EitherError` in favor of `either::Either`. See [PR 3337].
 
 - Remove `EitherTransport` in favor of implementing `Transport` on `either::Either`. See [PR XXXX].
 
@@ -21,7 +21,7 @@
 [PR 3097]: https://github.com/libp2p/rust-libp2p/pull/3097
 [PR 3090]: https://github.com/libp2p/rust-libp2p/pull/3090
 [PR 2972]: https://github.com/libp2p/rust-libp2p/pull/2972
-[PR XXXX]: https://github.com/libp2p/rust-libp2p/pull/XXXX
+[PR 3337]: https://github.com/libp2p/rust-libp2p/pull/3337
 
 # 0.37.0