Skip to content

Commit

Permalink
protocols/identify: Change default cache_size of Config to 100 (#2995)
Browse files Browse the repository at this point in the history
`Config` struct's member `cache_size` now defaults to `100`.
  • Loading branch information
efarg authored Nov 4, 2022
1 parent 280c51e commit ba14ffd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ required-features = ["full"]
name = "distributed-key-value-store"
required-features = ["full"]

# Passing arguments to the docsrs builder in order to properly document cfg's.
# Passing arguments to the docsrs builder in order to properly document cfg's.
# More information: https://docs.rs/about/builds#cross-compiling
[package.metadata.docs.rs]
all-features = true
Expand Down
4 changes: 4 additions & 0 deletions protocols/identify/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
# 0.41.0 [unreleased]

- Change default `cache_size` of `Config` to 100. See [PR 2995].

- Update to `prost-codec` `v0.3.0`.

- Update to `libp2p-core` `v0.38.0`.

- Update to `libp2p-swarm` `v0.41.0`.

[PR 2995]: https://github.com/libp2p/rust-libp2p/pull/2995

# 0.40.0

- Update dependencies.
Expand Down
6 changes: 2 additions & 4 deletions protocols/identify/src/behaviour.rs
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ impl Config {
initial_delay: Duration::from_millis(500),
interval: Duration::from_secs(5 * 60),
push_listen_addr_updates: false,
cache_size: 0,
cache_size: 100,
}
}

Expand Down Expand Up @@ -748,9 +748,7 @@ mod tests {
let mut swarm2 = {
let (pubkey, transport) = transport();
let protocol = Behaviour::new(
Config::new("a".to_string(), pubkey.clone())
.with_cache_size(100)
.with_agent_version("b".to_string()),
Config::new("a".to_string(), pubkey.clone()).with_agent_version("b".to_string()),
);

Swarm::new(transport, protocol, pubkey.to_peer_id())
Expand Down

0 comments on commit ba14ffd

Please sign in to comment.