Skip to content

Commit

Permalink
fix(multistream-select): remove cyclic dependency to libp2p-core
Browse files Browse the repository at this point in the history
All of the removed `dev-dependencies` are only for testing the upgrade procedure in `libp2p-core`. Ironically, this test does not use a single API of `multistream-select`. Thus, this test is simply misplaced in this crate. If we wanted to retain it, it should probably go into `libp2p` itself as that one already depends on all required crates.

Related: #4053.

Pull-Request: #4090.


  
Co-Authored-By: Thomas Eizinger <thomas@eizinger.io>
  • Loading branch information
thomaseizinger committed Jun 20, 2023
1 parent 8776fa8 commit 755de30
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 117 deletions.
5 changes: 0 additions & 5 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions misc/multistream-select/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ unsigned-varint = "0.7"
async-std = { version = "1.6.2", features = ["attributes"] }
env_logger = "0.10"
futures_ringbuf = "0.4.0"
libp2p-core = { workspace = true }
libp2p-yamux = { workspace = true }
libp2p-plaintext = { workspace = true }
libp2p-swarm = { workspace = true, features = ["async-std"] }
libp2p-identity = { workspace = true, features = ["ed25519"] }
quickcheck = { workspace = true }
rand = "0.8"
rw-stream-sink = { workspace = true }
Expand Down
107 changes: 0 additions & 107 deletions misc/multistream-select/tests/transport.rs

This file was deleted.

0 comments on commit 755de30

Please sign in to comment.