chore: update websockets #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
LGTM, I just want to note though that while the Websocket transport behavior is a breaking change, it's a breaking change in behavior only, and there is no reason why someone cannot use libp2p-websockets 0.15 with js-libp2p 0.29.x.
It's not necessary for this to land in 0.30, but since it's testing only it doesn't matter to consuming users.
That is true, but it might break local testing environments of users like in |
vasco-santos
added a commit
that referenced
this pull request
Dec 10, 2020
* chore: update websockets
vasco-santos
added a commit
that referenced
this pull request
Dec 16, 2020
* chore: update websockets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates websockets version, which comes with a BREAKING CHANGE on the filter. Only DNS+WSS addresses are now returned on filter by default in the browser. The tests were update to pass a custom filter so that we can test this locally with loopback websocket addresses
Needs: