refactor: dht #480
Merged
refactor: dht #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
refactor/dht
branch
from
2d93eaf to
275d873
Compare
* refactor: cleanup core test: auto dial on startup * fix: make hangup work properly * chore: fix lint * chore: apply suggestions from code review Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio>
vasco-santos
force-pushed
the
refactor/dht
branch
from
275d873 to
480373d
Compare
vasco-santos
commented
Nov 21, 2019
src/dht.js
Outdated
| dialer: { | ||
| dial: (peer, options) => node.dial(peer, options), | ||
| dialProtocol: (peer, protocols, options) => { | ||
| const recordedPeer = node.peerStore.get(peer.toB58String()) |
There was a problem hiding this comment.
When the dial is happening, if we try to dial using the peer-id, the peer-info stored gets replaced, removing the multiaddrs that previously existed:
https://github.com/libp2p/js-libp2p/blob/refactor/async-await/src/get-peer-info.js#L36-L41
I think we can tackle this once we get rid of peer-info
vasco-santos
commented
Nov 21, 2019
jacobheun
reviewed
Nov 22, 2019
This was referenced Nov 25, 2019
jacobheun
pushed a commit
that referenced
this pull request
Dec 12, 2019
* refactor: core async (#478) * refactor: cleanup core test: auto dial on startup * fix: make hangup work properly * chore: fix lint * chore: apply suggestions from code review Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio> * fix: provide libp2p dialer to the dht * chore: use dht release
jacobheun
pushed a commit
that referenced
this pull request
Jan 24, 2020
* refactor: core async (#478) * refactor: cleanup core test: auto dial on startup * fix: make hangup work properly * chore: fix lint * chore: apply suggestions from code review Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio> * fix: provide libp2p dialer to the dht * chore: use dht release
kumavis
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Apr 22, 2020
interface was updated here libp2p/js-libp2p#480
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
Bumps [p-event](https://github.com/sindresorhus/p-event) from 5.0.1 to 6.0.0. - [Release notes](https://github.com/sindresorhus/p-event/releases) - [Commits](sindresorhus/p-event@v5.0.1...v6.0.0) --- updated-dependencies: - dependency-name: p-event dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [9.3.7](libp2p/js-libp2p-kad-dht@v9.3.6...v9.3.7) (2023-06-15) ### Trivial Changes * Update .github/workflows/semantic-pull-request.yml [skip ci] ([94e4240](libp2p/js-libp2p-kad-dht@94e4240)) * Update .github/workflows/stale.yml [skip ci] ([b081831](libp2p/js-libp2p-kad-dht@b081831)) ### Dependencies * bump p-event from 5.0.1 to 6.0.0 ([libp2p#480](libp2p/js-libp2p-kad-dht#480)) ([ca1fdb7](libp2p/js-libp2p-kad-dht@ca1fdb7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async refactor for the new async version of
libp2p-kad-dht.As discussed on #472 , the
dhtapi is provided under_dhtas it should not be directly used.Needs: