This repository has been archived by the owner on Aug 23, 2019. It is now read-only.
fix: peer disconnect event and improve logging performance #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: clean up logging to prevent unneeded string formating
ghost
assigned 
vasco-santos
approved these changes
Mar 10, 2019
2 tasks
dirkmc
reviewed
Mar 11, 2019
alanshaw
approved these changes
Mar 11, 2019
50 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
peer-mux-closedevent was being emitted on connection close, even when no muxed connection was established. Since the connect event ,peer-mux-established, is emitted only after muxing, this PR makes the disconnect event in line with the connect event.This PR also moves any formatting of debug logs into the responsibility of the debugger. The
debugmodule immediately checks whether or not it is enabled for each logger namespace before doing any formatting, and returns early if not. This will prevent unneeded string formatting when debugging is not enabled, which will help improve performance.