Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Add WebAssembly support and the ability to Dial from browsers #55

Merged
merged 31 commits into from
Oct 8, 2019
Merged

Add WebAssembly support and the ability to Dial from browsers #55

merged 31 commits into from
Oct 8, 2019

Conversation

Stebalien
Copy link
Member

Rebased #51 with:

  • passing tests
  • the remaining concerns addressed

(see the last 4 commits for actual changes)

albrow and others added 28 commits September 30, 2019 16:59
@albrow @Stebalien
Implement bare bones Wasm support (needs to be cleaned up)
4616a50
@albrow @Stebalien
Make it possible to run browser tests with a single go test command
2f1f3fa
@albrow @Stebalien
Guarantee reading happens in order and add some comments
4ce5b9c
@albrow @Stebalien
return os.ErrNoDeadline where appropriate
24c6ac3
@albrow @Stebalien
Change go and js suffixes to native and browser
ab85fe1
@albrow @Stebalien
Revert to returning nil instead of os.ErrNoDeadline
729ffce
@albrow @Stebalien
Cache local and remote address
d4c1435
@albrow @Stebalien
Optimize readBlob by using the readAsBinaryString method
bd8fb2f
@albrow @Stebalien
Add better error handling to readBlob
d89bf69
@albrow @Stebalien
Revert back to using readAsArrayBuffer
05f6a8e
@albrow @Stebalien
Preserve message order by not using a goroutine in messageHandler
b3c6482
@albrow @Stebalien
Use ArrayBuffer type for binary data
faf224e 
This allows us to avoid the rather obtuse FileReader API and makes it
easier to read incoming data syncronously.
@albrow @Stebalien
Use a buffer of 1 for dataSignal channel
9de0cc8
@albrow @Stebalien
Add TODO for returning os.ErrNoDeadline
bfb657a
@albrow @Stebalien
Add proper error handling
c413b3d
@albrow @Stebalien
Expand comment about time.Sleep hack
4a58c98
@albrow @Stebalien
Call conn.Close if waitForOpen returns an error
aa28843
@albrow @Stebalien
Simplify Conn.Read logic
b84e264
@albrow @Stebalien
Simplify iteration over Uint8Array
642b9c2
@albrow @Stebalien
Set handlers to nil after releasing them
94d3354
@albrow @Stebalien
Use a sync.Once in Conn.Close
722bc5b
@albrow @Stebalien
Recover from uncaught JavaScript exceptions in Conn.Write
6e856e1
@albrow @Stebalien
Switch order of Call("close") and signalClose()
52047fc
@albrow @Stebalien
Remove unused constant
9329462
@Stebalien
Set firstErr before signaling the connection close
97e01a8
@Stebalien
Handle connection errors before handling data.
83d1e82
@Stebalien
test: auto-install wasm test dependency
077e2e4
@Stebalien
dep: update go-logging to fix panic in browsers
c99130b
@Stebalien Stebalien mentioned this pull request Oct 1, 2019
Closed
@Stebalien Stebalien merged commit 3098bba into master Oct 8, 2019
@Stebalien Stebalien deleted the wasm-support branch October 8, 2019 03:27
@albrow
Copy link
Contributor

albrow commented Oct 8, 2019

@Stebalien looks good at a glance. I should have time to do some testing on our end next week (after Devcon).

@Stebalien
Copy link
Member Author

Thanks!

@albrow albrow mentioned this pull request Oct 28, 2019
Closed
@albrow
Copy link
Contributor

albrow commented Nov 7, 2019 •
edited
Loading

@Stebalien sorry for the late reply. I can confirm that after updating our code to include these changes, our integration tests still pass. Thanks for your help implementing this 😄

@Stebalien
Copy link
Member Author

Awesome!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @albrow