fix(phys-addr-length): fix physical address length mismatch #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
separate gitignore change from PR
lixmal
added a commit
to netbirdio/netbird
that referenced
this pull request
Mar 19, 2024
This fixes the test that doesn't find routes on Linux with the newer version. Unfortunately we lose the windows bug fix from libp2p/go-netroute#29 that returns interfaces for us. It still works with returned next hop IP addresses currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
Fix physical address length mismatch.
As can be seen on the screenshot,
iface.HardwareAddrhas 6 bytes and should matchifRow.PhysAddr. However, the length ofifRow.PhysAddrbeing 8 bytes prevents that, even thoughifRow.PhysAddrLensays it should in fact be 6 bytes.The change in this PR has a check to prevent unlikely "out of bounds" error, while respecting
ifRow.PhysAddrLen.