fix: minimal autonat dialer #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the AutoNAT dialer spins up a full host with identify, ping, etc. this switches to a blankhost. This also avoids running a relay, listening on transports, etc (regression).
willscott
approved these changes
Mar 22, 2020
| if err != nil { | ||
| h.Close() | ||
| return nil, err | ||
| } | ||
|
|
||
| dialerHost := blankhost.NewBlankHost(dialer) | ||
| err = autoNatCfg.addTransports(ctx, dialerHost) |
There was a problem hiding this comment.
addTransports looks like it could plausibly be refactored to take a network directly, in which case we could just pass the dialer directly without ever creating the blank host. would that be more efficient?
There was a problem hiding this comment.
Unfortunately, transports can currently accept a Host through reflection magic and we can't really switch that to Network because some transports might need to register a stream listener (only available on host).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the AutoNAT dialer spins up a full host with identify, ping, etc. this switches to a blankhost.
This also avoids running a relay, listening on transports, etc (regression).