Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: uniform comment sentences #826

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

vasco-santos
Copy link
Member

After going through the code I found a few inconsistencies on comment sentences.

Some comment sentences did not end in a period, which causes inconsistent docs with the majority of libp2p docs and broader go ecosystem. golang/go/wiki/CodeReviewComments#comment-sentences recommends that we end with this period, which we mostly do in the codebase.

Also fixed a minor typo.

Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stebalien Stebalien merged commit 5a6c36d into libp2p:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants