Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nat: ignore mapping if external port is 0 #3094

Merged
merged 1 commit into from
Jan 10, 2025
Merged

nat: ignore mapping if external port is 0 #3094

merged 1 commit into from
Jan 10, 2025

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Dec 8, 2024

closes: #3057
rest of the work is in: #3075

closes: #3057
rest of the work is in: #3075

Co-authored-by: wlynxg <liuauthor@foxmail.com>
@sukunrt sukunrt requested a review from MarcoPolo December 8, 2024 10:57
@p-shahi p-shahi mentioned this pull request Dec 16, 2024
26 tasks
@p-shahi p-shahi mentioned this pull request Dec 26, 2024
20 tasks
@MarcoPolo MarcoPolo merged commit a2993c1 into master Jan 10, 2025
11 checks passed
sukunrt added a commit that referenced this pull request Jan 21, 2025
Co-authored-by: wlynxg <liuauthor@foxmail.com>
2color added a commit that referenced this pull request Jan 24, 2025
…bug-nat-port-mapping

* origin/marco/bring-go-nat-home: (75 commits)
  go mod tidy
  reference internal package for mockgen
  mod tidy test-plans
  Make changes to internal nat library
  ci: move to actions/upload-artifact@v4 (#3152)
  tcpreuse: fix rcmgr accounting when tcp metrics are enabled (#3142)
  fix(net/nat): data race problem of `extAddr` (#3140)
  test: fix failing test (#3141)
  quicreuse: make it possible to use an application-constructed quic.Transport (#3122)
  nat: ignore mapping if external port is 0 (#3094)
  tcpreuse: error on using tcpreuse with pnet (#3129)
  chore: Update contribution guidelines (#3134)
  tcp: fix metrics test build directive (#3052)
  webrtc: upgrade pion/webrtc to v4 (#3098)
  ci: get back on the main release track of release checker (#3117)
  webtransport: fix docstring comment for getCurrentBucketStartTime
  chore: release v0.38.1 (#3114)
  fix(httpauth): Correctly handle concurrent requests on server (#3111)
  ci: Install specific protoc version when generating protobufs (#3112)
  fix(autorelay): Move relayFinder peer disconnect cleanup to separate goroutine (#3105)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NATMap mapping failed, resulting in an observed address error
2 participants