Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locking issue introduced in 90eeff42fcd #123

Merged
merged 1 commit into from
Sep 29, 2016
Merged

Fix locking issue introduced in 90eeff42fcd #123

merged 1 commit into from
Sep 29, 2016

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Sep 29, 2016 •
edited
Loading

No description provided.

@Kubuxu Kubuxu added status/in-progress In progress need/review Needs a review labels Sep 29, 2016
whyrusleeping
whyrusleeping approved these changes Sep 29, 2016
View reviewed changes
Copy link
Contributor

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Kubuxu

@whyrusleeping whyrusleeping merged commit 67ed3ff into master Sep 29, 2016
@whyrusleeping whyrusleeping deleted the fix/nat/lock branch September 29, 2016 18:58
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Sep 29, 2016
marten-seemann added a commit that referenced this pull request Dec 22, 2021
@marten-seemann
fix flaky TestAutoNATIncomingEvents (#123)
cfb9b36
marten-seemann pushed a commit that referenced this pull request Jul 1, 2022
@Stebalien
Merge pull request #123 from libp2p/feat/rw-close
8ce67b0 
feat: update to go-libp2p-core 0.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
need/review Needs a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kubuxu @whyrusleeping