-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option for custom dns resolver #1073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we actually need to use the resolver somewhere?
the code is already there AFAICT, we just needed to add it to the basic host opts in config. Did I miss that? |
NATManager: cfg.NATManager, | ||
EnablePing: !cfg.DisablePing, | ||
UserAgent: cfg.UserAgent, | ||
MultiaddrResolver: cfg.MultiaddrResolver, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stebalien we use it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we just never wired this up...
No description provided.