This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
set an ALPN value in the tls.Config #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10.
This sets the application protocol (ALPN, see RFC 7301) to "libp2p". For TCP, use of ALPN is optional, but for QUIC, ALPN is mandatory, and the handshake fails if an endpoint doesn't send the ALPN extension, or if the two peers can't agree on a mutually supported application.
Since the the client sends this extension in the clear (it's part of the ClientHello message), this is one of the many ways that libp2p traffic sticks out. As part of our effort to make our traffic indistinguishable from normal web traffic, we might want to change this to the application name used by HTTP/2 or HTTP/3 at some point in the future, and use an upgrade mechanism like MASQUE.