This repository has been archived by the owner on May 26, 2022. It is now read-only.
Differentiate no addresses error from no good addresses #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
raulk
suggested changes
Mar 11, 2019
anacrolix
changed the title
anacrolix
changed the title
|
I'll squash this one when it's approved. |
raulk
approved these changes
Mar 13, 2019
|
@anacrolix Oh well, too late for squashing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address filtering is applied before considering returning an error. This adds an extra error if there are no addresses at all to differentiate this. I found this useful as sometimes addresses are filtered for having trailing /p2p components, which was confusing. A later PR may improve that too.
The error check is changed to determine if the backoff could be part of context completion, as opposed to returned by an arbitrary downstream context (but not part of the current context), which I believe to the real intention.