Use peer ID utilities to go from pubkey to peer ID #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents bugs for any key types that don't use the IPFS default SHA-256 hashing, like the Ed25519 keys which use the identity hash. In practice, Ed25519 keys don't need to be put to the DHT, but this algorithm is more future proof.
Stebalien
approved these changes
Aug 2, 2019
|
adding a test then will merge
…On Fri, Aug 2, 2019 at 12:18 Steven Allen ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26?email_source=notifications&email_token=AABUCWXTHZJ53RWK4AMBKJ3QCRM4PA5CNFSM4II7DDVKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCAOAO4Y#pullrequestreview-270272371>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABUCWVCROWIFK34VLXGONTQCRM4PANCNFSM4II7DDVA>
.
|
Also updates core and sets flag for .travis.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents bugs for any key types that don't use the IPFS default SHA-256 hashing, like the Ed25519 keys which use the identity hash. In practice, Ed25519 keys don't need to be put to the DHT, but this algorithm is more future proof.